Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility for "Allow IXP update" switch #600

Open
magrmagr opened this issue Nov 12, 2019 · 8 comments
Open

Visibility for "Allow IXP update" switch #600

magrmagr opened this issue Nov 12, 2019 · 8 comments
Assignees

Comments

@magrmagr
Copy link

@magrmagr magrmagr commented Nov 12, 2019

This copy-paste from e-mail conversation with Arnold.

New question.
As IXP operator, today we allocated new IP1 for some new customer (ISP1).
ISP1 reported that this IP1 allocated to some other ISP2, according
PeeringDB.

According our IXP data, this IP1 was is free state before we assign it to
the new customer.

Problem: I'm unable to check inside PeeringDB state of switch "Allow IXP
Update" for ASN ISP2.
I'd like to see this state to decide, should I wrote to ISP2 to fix this or
this is question to the support@peeringdb.com ?

Do you have plans to give IXP operators permission to view the state of
"Allow IXP Update" switch?

As far as I see, there is no Github issue open for it. If you want it, please open one.

Cheers
Arnold

@arnoldnipper arnoldnipper self-assigned this Nov 13, 2019
@arnoldnipper

This comment has been minimized.

Copy link
Contributor

@arnoldnipper arnoldnipper commented Nov 13, 2019

Proposal

  • Add one new field to the GUI, where the network is able to set the visibility of the field "Allow IXP Update" to [public, users, private]

  • Add two new fields to the API:

    • allow_ixp_update boolean
    • allow_ixp_update_visible string for visibility the same as the current poc records: public, users, private

allow_ixp_update_visible will default to private which means it will only display for users who are members of the org.

Q: does another system of permissions make more sense? I.e. it should be visible to users of all ix where the net is connected to.

@peeringdb/pc this is more or less the 1:1 counterpart to #249. Please discuss!

@grizz

This comment has been minimized.

Copy link
Member

@grizz grizz commented Nov 14, 2019

This is a completely separate issue, it's for the network's settings instead of the IXP's.

Honestly, the fact that "Allow IXP Update" isn't public was just an oversight as I recall, I'd be all for making it public.

I don't see a reason to have a visibility setting, so I'd propose we just make that field public to the API and website.

@magrmagr

This comment has been minimized.

Copy link
Author

@magrmagr magrmagr commented Nov 14, 2019

If there is no any specific reason why "Allow IXP Update" isn't public , I agree that much more simple to make it public (visible to all).

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

@arnoldnipper arnoldnipper commented Nov 14, 2019

I don't see a reason to have a visibility setting, so I'd propose we just make that field public to the API and website.

Fine by me as well. So let's do it! Another one from @peeringdb/pc is supporting it?

@grizz

This comment has been minimized.

Copy link
Member

@grizz grizz commented Nov 14, 2019

If it's not too controversial, let's tack on a line in global stats in the footer with a count of the networks with it enabled called "Automated Networks"?

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

@arnoldnipper arnoldnipper commented Nov 14, 2019

If it's not too controversial, let's tack on a line in global stats in the footer with a count of the networks with it enabled called "Automated Networks"?

+1 to have this added

@mcmanuss8

This comment has been minimized.

Copy link
Contributor

@mcmanuss8 mcmanuss8 commented Nov 15, 2019

+1 to:

A) Make "Allow IXP Update" publicly visible in the UI and API
B) Add a count of networks with "Allow IXP Update" set to true in the global stats at the page footer

@arnoldnipper arnoldnipper added this to the Consensus milestone Nov 15, 2019
@arnoldnipper

This comment has been minimized.

Copy link
Contributor

@arnoldnipper arnoldnipper commented Nov 15, 2019

The quorum for Consensus has been reached (@grizz @mcmanuss8 @arnoldnipper)

Summarizing:

  • Add new boolean field net.allow_ixp_update to the API
  • Add a line in global stats in the footer with a count (called "Automated Networks") of the networks which have "Allow IXP Update" enabled

@peeringdb/pc if you object do this within five working days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.