Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternative direction of writing, e.g. Arabic #618

Open
arnoldnipper opened this issue Jan 6, 2020 · 10 comments
Open

Support alternative direction of writing, e.g. Arabic #618

arnoldnipper opened this issue Jan 6, 2020 · 10 comments
Assignees

Comments

@arnoldnipper
Copy link
Contributor

@arnoldnipper arnoldnipper commented Jan 6, 2020

Now that Arabic is translated for 100% it should be put into production. Also right alignment of text is needed for Arabic as it is written from right to left.

@peeringdb/oc, please install Arabic. @peeringdb/pc, please support this issue

@arnoldnipper arnoldnipper added this to the 1 Decide milestone Jan 6, 2020
@arnoldnipper arnoldnipper self-assigned this Jan 6, 2020
@mcmanuss8

This comment has been minimized.

Copy link
Contributor

@mcmanuss8 mcmanuss8 commented Jan 6, 2020

Forgive my ignorance - wouldn't the Arabic strings be entered right to left in the translation tool?

+1 though, whatever we can do to get better language support always has my vote

@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Jan 6, 2020

Forgive my ignorance - wouldn't the Arabic strings be entered right to left in the translation tool?

This is not for translation.peeringdb.com, but for https://peeringdb.com, and https://{beta,tutorial}.peeringdb.com. This currently still looks like the attached.

HOME Page

@shane-kerr

This comment has been minimized.

Copy link

@shane-kerr shane-kerr commented Jan 7, 2020

+1

@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Jan 18, 2020

@Shawna, @vegu and @grizz, any questions on how to implement?

@vegu

This comment has been minimized.

Copy link
Contributor

@vegu vegu commented Jan 29, 2020

@arnoldnipper @peeringdb/pc

i understand that this needs right adjustment and right to left direction of text everywhere, but it sounds like this would need actual layout adjustment as well.

few quick examples i can think of are

  • column order in tables (advanced search result for example)
  • entity view layout (https://www.peeringdb.com/net/20)
    • flip label, value columns
    • flip the entire layout so network fields are on the right side and public peering exchange points are on the left?

thoughts?

@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Jan 29, 2020

i understand that this needs right adjustment and right to left direction of text everywhere, but it sounds like this would need actual layout adjustment as well.

I have asked Sara Alamin Mohamed Hassan from PCH to chime in. Sara did the translation.

@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Jan 29, 2020

Sara says: Yes, for Arabic it will be better to flip the entire layout, to make the
Arabic words in the correct order.

I have attached a sample for how the page should be. but also notice
that Arabic titles/text
arabic interface for peeringDB.pdf
need also to be aligned from rtl.

@vegu

This comment has been minimized.

Copy link
Contributor

@vegu vegu commented Jan 30, 2020

@arnoldnipper can you show the following screenshot to Sara and let me know if she thinks this looks good generally speaking (small glitches aside) - thanks

pdbrtl

@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Feb 2, 2020

@vegu, Sara says: The screenshot is perfect. The Arabic words and alignment are correct.

@job

This comment has been minimized.

Copy link
Contributor

@job job commented Feb 9, 2020

Looks great indeed, +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.