Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MTU field #658

Open
arnoldnipper opened this issue Mar 5, 2020 · 3 comments
Open

Improve MTU field #658

arnoldnipper opened this issue Mar 5, 2020 · 3 comments
Assignees
Milestone

Comments

@arnoldnipper
Copy link
Contributor

@arnoldnipper arnoldnipper commented Mar 5, 2020

The current release forces you to set a non-negative value. However, 37% of all ixlan records have set MTU to null. If you now edit the LAN field you most likely will have to edit the MTU.

Proposal:

  • change fields with value null to 1500
  • check for a reasonable minimum. 576?
  • check for a reasonable maximum. 65535?
@arnoldnipper arnoldnipper added this to the 1 Decide milestone Mar 5, 2020
@arnoldnipper arnoldnipper self-assigned this Mar 5, 2020
@netravnen

This comment has been minimized.

Copy link

@netravnen netravnen commented Mar 5, 2020

check for a reasonable maximum. 65535?

I am in favour of this value being

  1. the largest commonly used IP MTU (e.g. 9000), or
  2. The largest known hardware MTU currently supported by most routing/switching hardware (e.g. 9216, read more)
@arnoldnipper

This comment has been minimized.

Copy link
Contributor Author

@arnoldnipper arnoldnipper commented Mar 5, 2020

I am in favour of this value being

What if the ix is not using Ethernet?

@shane-kerr

This comment has been minimized.

Copy link

@shane-kerr shane-kerr commented Mar 6, 2020

If we have to pick a value, I'd suggest 0. That is actually not allowed in IP packets but will match our constraints. Picking an allowed value means getting it wrong sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.