Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make sure we unsubscribe from published data when switching between views #4

Closed
mitar opened this Issue · 3 comments

1 participant

Mitar
Mitar
Owner

Make sure we unsubscribe from published data when switching between views. Probably this is done automatically? But maybe it is not.

Mitar
Owner

Currently it is done that when switching between views all session values are reset. We should check what happens if then some of session values are set back to the previous value. Maybe we should switch to iron-router. So it is necessary to analyze how things are being reactively changed.

Mitar mitar referenced this issue from a commit
Mitar mitar One too many reload.
Refactored routing code so that it does not reset all session values
before every routing. See #4
5dd8f62
Mitar
Owner

Checked around and it seems that currently the only place where we subscribe but never unsubscribe is when user clicks on the preview link in search results.

Mitar
Owner

Sometimes it is maybe easier to simply do a method call and get data? If reactivity is not important.

Mitar mitar referenced this issue
Merged

Search cleanup #328

Mitar mitar closed this in e3ca0f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.