Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirDrop like peer discovery #154

Open
ivelin opened this issue Dec 15, 2019 · 2 comments
Open

AirDrop like peer discovery #154

ivelin opened this issue Dec 15, 2019 · 2 comments

Comments

@ivelin
Copy link
Contributor

@ivelin ivelin commented Dec 15, 2019

Is there interest in peer discovery extensions?

Why:

  • Currently peerjs-server leaves it to developers to find ways to exchange their IDs so they can connect. This is a perfectly valid design choice for ultimate flexibility.
  • It would be convenient for developers if there are canned peering mechanisms for some of the common use cases.
  • One such use case is proximity peering. It applies to a lot of real world apps, including peerjs's own theater cues example.

What:

  • AirDrop like peering experience when peers are in close physical proximity.

How:

  • Assuming peers are located physically in the same room, logged into the same WiFi/LAN and sharing the same Public IP address.
  • See sharedrop.io for a nice implementation. Its based on a peerjs fork. It relies on Firebase realtime databse, which I don't think is a necessary dependency with peerjs-server.
  • See Ambianic PnP for a peerjs-server fork with room management extension. Happy to contribute the code back to peerjs-server if there is interest.

Ivelin

@afrokick

This comment has been minimized.

Copy link
Member

@afrokick afrokick commented Dec 15, 2019

I like the idea of rooms system. It should be pluggable into exists core.

@ivelin

This comment has been minimized.

Copy link
Contributor Author

@ivelin ivelin commented Feb 14, 2020

The room API implementation has been finished and tested for several weeks. Please take a look if you have a chance and let me know if its of interest to merge into the original repo. Here is the forked repo:
https://github.com/ambianic/ambianic-pnp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.