Firefox support #24

Closed
boombatower opened this Issue Mar 6, 2013 · 10 comments

Comments

Projects
None yet
3 participants

Most of the stuff I read seems to indicate firefox supports datachannel of the updated spec, with the notable exception of connectDataConnection. Are there major reasons for not trying to support firefox, as I see compatibility page shows that not even 22.0a1 will run peerjs which is rather far into the future?

Owner

michelle commented Mar 6, 2013

No major reason, just that as of now there isn't too much demand for it, and additionally there is no interoperability with Chrome. The code required to support Firefox will add a lot of complexity and additional branching in the library.

There is some unfinished Firefox code in the library currently that's been commented out, so you can get an idea of the stuff that's different (exchanging port numbers between Peers, creating offers in different places, handlers like onnegotiationneeded that don't quite fire, requiring a media stream to make a DataChannel connection, etc).

But you're right--there's no major reason that we should continue to hold off on supporting Firefox. I was actually going to work on Firefox support this weekend, and that's become a higher priority for me than supporting media streams (there are lots of libraries out there for that already that have great APIs!).

Owner

michelle commented Mar 8, 2013

A bunch of bugs were closed today in Firefox, so I will push to make PeerJS Firefox compatible by the end of next week.

Owner

michelle commented Mar 24, 2013

Update: Worked on supporting multiple DataChannels instead--this breaks Firefox stuff I was previously working on, so ETA is unknown as of now. :(

@ghost ghost assigned michelle Mar 26, 2013

michelle added a commit that referenced this issue Mar 31, 2013

#24: multiple DCs are not configurable on FF due to no answer/offer …
…exchange. a settimeout is probably not worth it

michelle added a commit that referenced this issue Apr 1, 2013

Merge pull request #36 from peers/ff
Firefox support, issue #24.
Owner

michelle commented Apr 1, 2013

Closed by 72424b3

@michelle michelle closed this Apr 1, 2013

Owner

michelle commented Apr 1, 2013

Reopening this because the latest Firefox Nightly builds break things.

Release will need to be delayed to find a suitable workaround.

@michelle michelle reopened this Apr 1, 2013

Owner

michelle commented Apr 1, 2013

Currently confirmed to work for Nightly 22.0a1 (2013-03-04). See https://groups.google.com/forum/?fromgroups=#!topic/peerjs/WG8U-16pNoE

piranna commented Apr 24, 2013

Thanks for the info :-)

2013/4/24 Michelle Bu notifications@github.com

For reference:
http://mozilla.github.io/webrtc-landing/DataChannel_changes.html


Reply to this email directly or view it on GitHubhttps://github.com/peers/peerjs/issues/24#issuecomment-16902148
.

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux

Owner

michelle commented Apr 24, 2013

Yeah I'm back to working on this today. Can't believe I didn't find that earlier--hopefully it will be straightforward now given that information :).

piranna commented Apr 24, 2013

I hope so, seems that it got to be simplified... I'll take a look on it
after my exams (about June or July... :-S ) to try to use native ones at
last :-)

2013/4/24 Michelle Bu notifications@github.com

Yeah I'm back to working on this today. Can't believe I didn't find that
earlier--hopefully it will be straightforward now given that information :).


Reply to this email directly or view it on GitHubhttps://github.com/peers/peerjs/issues/24#issuecomment-16902470
.

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux

@michelle michelle closed this in 60dec67 Apr 24, 2013

bchu pushed a commit to bchu/peerjs that referenced this issue Jun 29, 2013

bchu pushed a commit to bchu/peerjs that referenced this issue Jun 29, 2013

#24: multiple DCs are not configurable on FF due to no answer/offer …
…exchange. a settimeout is probably not worth it

bchu pushed a commit to bchu/peerjs that referenced this issue Jun 29, 2013

Merge pull request #36 from peers/ff
Firefox support, issue #24.

bchu pushed a commit to bchu/peerjs that referenced this issue Jun 29, 2013

bchu pushed a commit to bchu/peerjs that referenced this issue Jun 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment