Vignette upgrades

[pegeler]

No description provided.

[kampfsca]

The utilization of uniroot is cool. I wonder if some of the functions in the vignette could be integrated into the package proper.

[pegeler]

I'd be interested in doing that. The way it's set up now is a little cumbersome because we would need pass a lot of information to the partially applied function via closure. I pull from the global environment here because it's in a controlled environment. Another approach that might be cleaner would be to take in an already computed power.cmh object and get everything needed from there. I'll think on that but I'd really like to prioritize getting these vignettes polished up so that I can submit them as a paper before adding any new functionality.

PR is welcome if you want to do it. Otherwise one of us can make an issue?

[kampfsca]

Mostly cosmetic changes - we're adding spaces after commas now? Switching from sapply to vapply for a few functions is a nice upgrade. Looks solid.

[pegeler]

Mostly cosmetic changes - we're adding spaces after commas now? Switching from sapply to vapply for a few functions is a nice upgrade. Looks solid.

Yes, mostly cosmetic changes, plus the little uniroot trick. Most of this is ground work for combining all three vignettes into a nicely typeset paper. Adding spaces after commas is the "correct" style these days; I would have caught that if I was running this through a linter.

Feel free to make a PR adding yourself as a "ctb" or "rev"