Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixes issue #104: DateTimes before "01.01.1970" resulting in a "Value is out of bounds" TypeError exception. #106

Closed
wants to merge 1 commit into from

2 participants

@stf1981

See issue #104

@patriksimek
Collaborator

This PR cannot be merged because it breaks SmallDateTime values. SmallDateTime range is 1900-01-01 through 2079-06-06. See docs for more info.

DateTime was fixed in 1bdadb3. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 3, 2013
  1. @stf1981

    Fixes Issue #104: DateTimes before "01.01.1970" resulting in a "Value…

    stf1981 authored
    … is out of bounds" TypeError exception.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/data-type.coffee
View
4 src/data-type.coffee
@@ -91,7 +91,7 @@ TYPE =
minutes = (parameter.value.getHours() * 60) + parameter.value.getMinutes()
buffer.writeUInt8(4)
- buffer.writeUInt16LE(days)
+ buffer.writeInt16LE(days)
buffer.writeUInt16LE(minutes)
else
buffer.writeUInt8(0)
@@ -137,7 +137,7 @@ TYPE =
threeHundredthsOfSecond = Math.floor(threeHundredthsOfSecond)
buffer.writeUInt8(8)
- buffer.writeUInt32LE(days)
+ buffer.writeInt32LE(days)
buffer.writeUInt32LE(threeHundredthsOfSecond)
else
buffer.writeUInt8(0)
Something went wrong with that request. Please try again.