Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add placeholder event handlers to suppress crash in final #80

Merged
merged 2 commits into from

2 participants

@drudge

No description provided.

@pekim
Owner

Can you provide some details of what circumstances cause a problem please? If I can, I'd like to add an integration test to reproduce the problem.

@drudge

@pekim I'll try, but I actually added this fix to my local version about 7 months ago and can't remember the exact case we were dealing with.

My second commit fixes a problem where passing a database would not actually work, it would always use the default database configured in SQL Server.

@pekim pekim merged commit 3e51305 into pekim:master
@pekim
Owner

This is not correct. database is meant to be a property of options.
This is documented at http://pekim.github.com/tedious/api-connection.html#function_newConnection .

@momow momow referenced this pull request from a commit in momow/tedious
@bretcope bretcope Implemented CRUD endpoints. Untested. ref #80 #79 #78 #77 2a067eb
@momow momow referenced this pull request from a commit in momow/tedious
@bretcope bretcope Fixed and tested CRUD API endpoints. fix #77 fix #78 fix #79 fix #80 7260bac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 21, 2013
  1. @drudge
Commits on Feb 22, 2013
  1. @drudge

    Fix passing of database config

    drudge authored
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −1 src/connection.coffee
View
6 src/connection.coffee
@@ -140,6 +140,10 @@ class Connection extends EventEmitter
# Do nothing. The connection was probably closed by the client code.
connectTimeout: ->
# Do nothing, as the timer should be cleaned up.
+ message: ->
+ # Do nothing
+ socketError: ->
+ # Do nothing
constructor: (@config) ->
@defaultConfig()
@@ -369,7 +373,7 @@ class Connection extends EventEmitter
loginData =
userName: @config.userName
password: @config.password
- database: @config.options.database
+ database: @config.database
packetSize: @config.options.packetSize
tdsVersion: @config.options.tdsVersion
Something went wrong with that request. Please try again.