New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning Geonames results from `/reverse` #1045

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@orangejulius
Member

orangejulius commented Oct 23, 2017

While the eventual goal for our /reverse endpoint is to only allow returning administrative results and addresses, the /nearby endpoint that would compliment it and allow users to see venues near a given coordinate is not yet production ready.

Until it is we want to be able to return Geonames venues, especially since we still can return OSM venues. However, we were returning an incorrect error message that prevented this.

This PR makes that error message only appear when a user tries to return coarse Geonames results from /reverse, which is no longer possible since there aren't really many geometries in Geonames at all.

It also points users who do see the error to our new Geonames removal issue for more context.

Fixes #930
Connects pelias/acceptance-tests#447

orangejulius added some commits Oct 23, 2017

Add friendly, coarse specific error message to reverse
This error message is updated to mention the coarse-reverse only nature
of Geonames support removal. It also links to the
[tracking ticket](pelias/acceptance-tests#447)
for Geonames removal which should help provide more context to users.

@orangejulius orangejulius self-assigned this Oct 23, 2017

@orangejulius orangejulius requested review from trescube and dianashk Oct 23, 2017

@wafflebot wafflebot bot added the in progress label Oct 23, 2017

@dianashk

Looks great! Nice tests.

@orangejulius orangejulius merged commit 761a04e into master Oct 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment