Allow Elasticsearch index name to be set from pelias-config #595

Merged
merged 3 commits into from Jul 22, 2016

Conversation

Projects
None yet
4 participants
@orangejulius
Member

orangejulius commented Jul 21, 2016

The index name value will be read from pelias config, under the config.api.indexName property. pelias/config#30 (released in pelias-config-2.1.0) sets the default for this value to pelias, so it will always be defined and will have the same behavior as before with no changes in ~/pelias.json.

I've tested this locally quite a bit in addition to the unit tests which should cover everything, but am especially curious to know if there's anything I missed.

Connects #334

orangejulius added some commits Jul 19, 2016

@orangejulius

This comment has been minimized.

Show comment
Hide comment
@orangejulius

orangejulius Jul 21, 2016

Member

Note: after merging to master I'll be merging this PR directly into the production branch, so that we can use it to adjust our indices in production

Member

orangejulius commented Jul 21, 2016

Note: after merging to master I'll be merging this PR directly into the production branch, so that we can use it to adjust our indices in production

@missinglink

This comment has been minimized.

Show comment
Hide comment
Member

missinglink commented Jul 22, 2016

LGTM

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jul 22, 2016

Contributor

:shipit:

Contributor

trescube commented Jul 22, 2016

:shipit:

@orangejulius orangejulius merged commit ae26dba into master Jul 22, 2016

3 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius removed the in review label Jul 22, 2016

@orangejulius orangejulius deleted the 334-configurable-index-name branch Jul 22, 2016

orangejulius added a commit that referenced this pull request Jul 22, 2016

Fix missing parameter
This should have been in #595, but was
misssed until found during testing on dev2

je-l pushed a commit to nlsfi/pelias-api that referenced this pull request Aug 31, 2017

Merge pull request #595 from pelias/334-configurable-index-name
Allow Elasticsearch index name to be set from pelias-config

je-l pushed a commit to nlsfi/pelias-api that referenced this pull request Aug 31, 2017

Fix missing parameter
This should have been in pelias#595, but was
misssed until found during testing on dev2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment