All structured queries show result match_type as fallback #780

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
2 participants
@dianashk
Contributor

dianashk commented Jan 13, 2017

Fixes pelias/pelias#493

Looks like all queries of the fallback variety were suffering from this issue, not only structured. It would show up anytime there was a query that had city identified by the query parser.

@dianashk dianashk self-assigned this Jan 13, 2017

@dianashk dianashk added in review and removed in progress labels Jan 13, 2017

@orangejulius

lots of code but it looks great

+ *
+ * They do not map 1:1 to our layers so the following somewhat complicated
+ * mapping structure is needed to set clear rules for comparing what was requested
+ * by the query and what has been received as a result to determine if a fallback occurred.

This comment has been minimized.

@orangejulius

orangejulius Jan 17, 2017

Member

yikes. complicated, but i think necessary and pretty readable.

@orangejulius

orangejulius Jan 17, 2017

Member

yikes. complicated, but i think necessary and pretty readable.

+
+ return (
+ // verify that more granular properties are not set
+ notSet(req.clean.parsed_text, rule.notSet) &&

This comment has been minimized.

@orangejulius

orangejulius Jan 17, 2017

Member

this part ends up really clean, quite nice

@orangejulius

orangejulius Jan 17, 2017

Member

this part ends up really clean, quite nice

@dianashk dianashk merged commit 307598c into master Jan 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dianashk dianashk removed the in review label Jan 24, 2017

@missinglink missinglink referenced this pull request Jan 24, 2017

Merged

merge master->staging #786

je-l pushed a commit to nlsfi/pelias-api that referenced this pull request Aug 31, 2017

Diana Shkolnikov
Merge pull request #780 from pelias/fix-match-type-structured
All structured queries show result match_type as fallback

@orangejulius orangejulius deleted the fix-match-type-structured branch Nov 14, 2017

@orangejulius orangejulius referenced this pull request Jun 13, 2018

Open

Remove many hardcoded lists of layers and sources #1161

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment