feat: Add default index names for API and schema #30

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
4 participants
@orangejulius
Member

orangejulius commented Jul 14, 2016

As part of pelias/api#334, we want to be able to configure the Elasticsearch index name that is used by the API, and separately, the importers.

This is a backwards compatible config that adds configuration defaults
for Elasticsearch index names for both the API and schema (which is also
intended to be used by the importers).

While this change by itself doesn't affect anything, it is what will determine what the config parameter names are for changing which Elasticsearch index to use, so if there is anything confusing about the current names, this is the best time to change them.

Connects pelias/api#334

feat: Add default index names for API and schema
This is a backwards compatible config that adds configuration defaults
for Elasticsearch index names for both the API and schema (which is also
intended to be used by the importers).

Connects pelias/api#334
@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jul 14, 2016

Contributor

:shipit:

Contributor

trescube commented Jul 14, 2016

:shipit:

@orangejulius orangejulius referenced this pull request in pelias/model Jul 15, 2016

Merged

Configurable index name #39

@dianashk

This comment has been minimized.

Show comment
Hide comment
@dianashk

dianashk Jul 19, 2016

Contributor

LGTM

Contributor

dianashk commented Jul 19, 2016

LGTM

@missinglink

This comment has been minimized.

Show comment
Hide comment
Member

missinglink commented Jul 19, 2016

LGTM

@orangejulius orangejulius merged commit c049920 into master Jul 19, 2016

3 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius removed the in review label Jul 19, 2016

@orangejulius orangejulius deleted the configurable_index_name branch Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment