Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a limit on duration of pelias elastic wait command #34

Closed
orangejulius opened this issue Oct 27, 2018 · 0 comments · Fixed by #35
Closed

Put a limit on duration of pelias elastic wait command #34

orangejulius opened this issue Oct 27, 2018 · 0 comments · Fixed by #35
Assignees

Comments

@orangejulius
Copy link
Member

Currently, pelias elastic wait will run forever waiting for an Elasticsearch instance to come up. If there's a problem, such as in #33, it will prevent automated scripts from continuing, or failing. In the case of a user running pelias but having an issue, it might give them a false sense that things are okay.

We should set a reasonable limit, it could probably be as low as 60 seconds, for how long pelias elastic wait will wait, after which it should error. This is more than enough time for a functioning Elasticsearch instance to come up, even if it has lots of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant