feat(elasticsearch-5): Remove X-Pack extension #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X-Pack extensions to Elasticsearch are proprietary addons for additional functionality, none of which is needed by Pelias. In the past, we've made due with disabling some of them by environment variable, however that still leaves them present to emit scary warnings about licenses. These warnings probably are ok to ignore, again since Pelias does not use any X-Pack features. However, its best to avoid scary warnings where possible, so this change removes the X-Pack plugin completely. Fixes #110
Closed
|
Very nice, do we need to also update https://github.com/pelias/kubernetes/blob/master/elasticsearch/packer/scripts/elasticsearch.sh ? |
|
It doesn't look like it. I don't believe the AMIs built by packer have X-Pack installed. After spinning one up I don't see the warnings, and the x-pack plugin is not installed: |
calpb
pushed a commit
to sorelle/docker
that referenced
this pull request
Mar 29, 2021
feat(elasticsearch-5): Remove X-Pack extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X-Pack extensions to Elasticsearch are proprietary addons for
additional functionality, none of which is needed by Pelias.
In the past, we've made do with disabling some of them by environment
variable, however that still leaves them present to emit scary warnings
about licenses. These warnings probably are ok to ignore, again since
Pelias does not use any X-Pack features.
However, its best to avoid scary warnings where possible, so this change
removes the X-Pack plugin completely.
Fixes #110