Removing the extra white space from the middle of street names #130

Merged
merged 1 commit into from Jun 29, 2016

Conversation

Projects
None yet
3 participants
@avulfson17
Contributor

avulfson17 commented Jun 29, 2016

Fixes #69

@avulfson17 avulfson17 self-assigned this Jun 29, 2016

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jun 29, 2016

Contributor

:shipit:

Contributor

trescube commented Jun 29, 2016

:shipit:

@orangejulius

This comment has been minimized.

Show comment
Hide comment
Member

orangejulius commented Jun 29, 2016

LGTM

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jun 29, 2016

Contributor

On second thought, this seems awfully professional (not your bad, @avulfson17), can it be done with lodash .replaces?

Contributor

trescube commented Jun 29, 2016

On second thought, this seems awfully professional (not your bad, @avulfson17), can it be done with lodash .replaces?

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jun 29, 2016

Contributor

Scratch that, it's fine, the regex for multi-token in lodash would be pretty complex.

Contributor

trescube commented Jun 29, 2016

Scratch that, it's fine, the regex for multi-token in lodash would be pretty complex.

@avulfson17 avulfson17 merged commit f55c5c3 into master Jun 29, 2016

3 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avulfson17 avulfson17 removed the in review label Jun 29, 2016

@orangejulius orangejulius deleted the normalize-street-names branch Jul 2, 2016

orangejulius added a commit to pelias/acceptance-tests that referenced this pull request Jul 6, 2016

Mark address parsing test passed
It was failing due to incorrect whitespace, but is now fixed:
pelias/openaddresses#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment