GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempts to standardize capitalization in street names such that each word begins with a capital.
Fix order of actual and expected parameters in test
Ensures title case capitalization for street names
Added test cases for capitalization with non ASCII characters
Although this still probably needs to be more thoroughly done
Updating the functional test so the capitalization works properly
This is a really hacky fix. Ideally we should handle cases where words in an address shouldn't be capitalized
I'd love to see some tests in non latin alphabets. It wouldn't need to work for all languages, just best to check that it doesn't break japanese/thai/cyrillic/tamil etc.
@missinglink: @avulfson17 is way ahead of you 😃
did the input have to change? shouldn't this have been tranformed to St anyway since the code tests each token in the input string separately?
I guess this is just the test to verify that there is a chance that nothing is changed. All good.