Fix capitalization #131

Merged
merged 4 commits into from Jul 28, 2016

Conversation

Projects
None yet
4 participants
@avulfson17
Contributor

avulfson17 commented Jun 29, 2016

Attempts to standardize capitalization in street names such that each word begins with a capital.

Fixes #95

Updating the functional test so the capitalization works properly
This is a really hacky fix. Ideally we should handle cases where words in an address shouldn't be capitalized

@orangejulius orangejulius added in review and removed in progress labels Jun 30, 2016

@orangejulius

This comment has been minimized.

Show comment
Hide comment
Member

orangejulius commented Jun 30, 2016

:shipit:

@missinglink

This comment has been minimized.

Show comment
Hide comment
@missinglink

missinglink Jul 1, 2016

Member

I'd love to see some tests in non latin alphabets. It wouldn't need to work for all languages, just best to check that it doesn't break japanese/thai/cyrillic/tamil etc.

Member

missinglink commented Jul 1, 2016

I'd love to see some tests in non latin alphabets. It wouldn't need to work for all languages, just best to check that it doesn't break japanese/thai/cyrillic/tamil etc.

@orangejulius

This comment has been minimized.

Show comment
Hide comment
@@ -74,14 +74,73 @@ tape( 'cleanupStream trims leading 0\'s from house numbers', function(test) {
tape ( 'cleanupStream trims white space in street field', function(test){
var input = {
- STREET: '34 West\t 93rd \nst'
+ STREET: '34 West\t 93rd \nSt'

This comment has been minimized.

@dianashk

dianashk Jul 26, 2016

Contributor

did the input have to change? shouldn't this have been tranformed to St anyway since the code tests each token in the input string separately?

@dianashk

dianashk Jul 26, 2016

Contributor

did the input have to change? shouldn't this have been tranformed to St anyway since the code tests each token in the input string separately?

This comment has been minimized.

@dianashk

dianashk Jul 26, 2016

Contributor

I guess this is just the test to verify that there is a chance that nothing is changed. All good.

@dianashk

dianashk Jul 26, 2016

Contributor

I guess this is just the test to verify that there is a chance that nothing is changed. All good.

@dianashk

This comment has been minimized.

Show comment
Hide comment
@dianashk

dianashk Jul 26, 2016

Contributor

:shipit:

Contributor

dianashk commented Jul 26, 2016

:shipit:

@orangejulius orangejulius merged commit fc92658 into master Jul 28, 2016

3 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius removed the in review label Jul 28, 2016

@orangejulius orangejulius deleted the fix-capitalization branch Aug 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment