New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature whitelist - re: aeroway #280

Merged
merged 3 commits into from May 23, 2017

Conversation

Projects
None yet
2 participants
@missinglink
Member

missinglink commented May 22, 2017

reduce target aeroway values to only those enumerated in a whitelist

see issue pelias/pelias#573 for more detail.

this PR changes our broad aeroway+name filter to a more selective one.

more notes on the issue linked above.

closes pelias/pelias#573

@missinglink

This comment has been minimized.

Show comment
Hide comment
@missinglink

missinglink May 23, 2017

Member

I'm now thinking we drop 'aeroway~gate+name', the gate names are noisy, generally things like M14 or A, B etc.

Since they're only really applicable for indoor routing in an area that is generally navigated by signage, I'm thinking they would more often be a hinderance than a help.

Member

missinglink commented May 23, 2017

I'm now thinking we drop 'aeroway~gate+name', the gate names are noisy, generally things like M14 or A, B etc.

Since they're only really applicable for indoor routing in an area that is generally navigated by signage, I'm thinking they would more often be a hinderance than a help.

@missinglink

This comment has been minimized.

Show comment
Hide comment
@missinglink

missinglink May 23, 2017

Member

added two commits:

  • remove 'aeroway~gate+name'
  • improved tests
Member

missinglink commented May 23, 2017

added two commits:

  • remove 'aeroway~gate+name'
  • improved tests

@missinglink missinglink merged commit 494f247 into master May 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius deleted the feature_whitelist_aeroway branch Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment