search results for San Francisco should not use math centroid #356

Closed
burritojustice opened this Issue Jun 8, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@burritojustice

should return label centroid..

latitude 37.778008
longitude -122.431272

not math centroid (halfway to the Farallons)

"features": [
{
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [
-122.693976,
37.759715
]
},

@orangejulius orangejulius added the bug label Jun 8, 2016

@orangejulius orangejulius self-assigned this Jun 8, 2016

@orangejulius orangejulius referenced this issue in pelias/acceptance-tests Jun 8, 2016

Merged

Add San Francisco label centroid to SF tests #247

@orangejulius

This comment has been minimized.

Show comment
Hide comment
@orangejulius

orangejulius Jun 8, 2016

Member

I can confirm this is broken.

sf

I suspect what happens is the Geonames result (which has a Farallon-proof lat/lon) was coming up first until recently, so we didn't notice. Test cases with lat/lon have (finally) been added and the fix should go out in our build starting early tomorrow night, for release by early next week.

Member

orangejulius commented Jun 8, 2016

I can confirm this is broken.

sf

I suspect what happens is the Geonames result (which has a Farallon-proof lat/lon) was coming up first until recently, so we didn't notice. Test cases with lat/lon have (finally) been added and the fix should go out in our build starting early tomorrow night, for release by early next week.

@orangejulius

This comment has been minimized.

Show comment
Hide comment
@orangejulius

orangejulius Jun 13, 2016

Member

And, fixed!
screenshot from 2016-06-13 14-31-02

Member

orangejulius commented Jun 13, 2016

And, fixed!
screenshot from 2016-06-13 14-31-02

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Jun 13, 2016

Contributor

nice

Contributor

trescube commented Jun 13, 2016

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment