New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic and tests 20-sept-17 #49

merged 12 commits into from Sep 22, 2017


None yet
2 participants

missinglink commented Sep 21, 2017

Yesterday I attempted to perform a new build of this repo with the latest whosonfirst data.

There were several failures due to changes of data and changes in the way properties are being handled since the last build.

This PR fixes these issues and brings the repo up-to-date with all the work being done by the wof team.

  • guard code against whosonfirst-data/whosonfirst-data#950
  • import wof:parent_id (as well as wof:hierarchy), as some records have had their hierarchy deleted.
  • ensure we import mz:is_current of both 1 and -1 (we rely on many -1 records)
  • update test cases for records which have been superseded by another record (confirmed by hand)
  • added several tests for Korean place names (which worked fine without any modification required)
  • add edges command to repl for ease of debugging
  • add wof:parent_id to list of fields to be extracted from wof sources
  • remove 'disambiguation' tokens from name suffix.
  • modifed the script (which publishes the builds) to also archive a datestamped copy
  • remove tokens which are -1 or entirely numeric

after these changes, all tests are passing with the exception of the capital city test for Noumea, New Caledonia, I have opened bug report whosonfirst-data/whosonfirst-data#954 to resolve this.

as a bit of an aside.. the workflow for the travis tests is a bit weird, I need to publish the data before the code review or the tests fail!?

@missinglink missinglink requested a review from orangejulius Sep 22, 2017


🌏 !!

@missinglink missinglink merged commit 2706f2e into master Sep 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@wafflebot wafflebot bot removed the in review label Sep 22, 2017

@orangejulius orangejulius deleted the update-20-sept-17 branch May 19, 2018

@orangejulius orangejulius restored the update-20-sept-17 branch May 19, 2018

@orangejulius orangejulius deleted the update-20-sept-17 branch May 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment