New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added request logging with response times #59

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@trescube
Contributor

trescube commented Oct 3, 2017

No description provided.

@trescube trescube added the in review label Oct 3, 2017

@trescube trescube self-assigned this Oct 3, 2017

Show outdated Hide outdated package.json Outdated
@orangejulius

Code looks good to me. Unfortunately the way the Travis tests are set up right now, they'll only ever pass on the same day we've pushed data. So either we merge anyway (the tests with the latest data passed on my machine), build new data, or figure out a new way to test.

@trescube trescube merged commit 3f6bd48 into master Oct 3, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details

@trescube trescube deleted the add-access-logs branch Oct 3, 2017

@wafflebot wafflebot bot removed the in review label Oct 3, 2017

@missinglink

This code looks fairly generic, could we include this middleware in the pelias/logger repo to avoid duplication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment