use `wof:label` for name instead of `wof:name` when available #139

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
2 participants
@trescube
Contributor

trescube commented Sep 26, 2016

Fixed #134

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Sep 26, 2016

Contributor

I found an example where this isn't ideal:

https://whosonfirst.mapzen.com/spelunker/id/101723183/#10/36.1869/-86.7852

This is the locality record for Nashville, TN (a pretty big city). The wof:name is Nashville but the wof:label is Nashville-Davidson County. See whosonfirst-data/whosonfirst-data#482

Contributor

trescube commented Sep 26, 2016

I found an example where this isn't ideal:

https://whosonfirst.mapzen.com/spelunker/id/101723183/#10/36.1869/-86.7852

This is the locality record for Nashville, TN (a pretty big city). The wof:name is Nashville but the wof:label is Nashville-Davidson County. See whosonfirst-data/whosonfirst-data#482

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Sep 26, 2016

Contributor

Don't merge until we get an answer on the Nashville issue.

Contributor

trescube commented Sep 26, 2016

Don't merge until we get an answer on the Nashville issue.

@orangejulius

orangejulius approved these changes Oct 14, 2016 edited

Looks like the Nashville label was reverted so the name field will take effect and everything will be ok. The code looks great, are we ready to merge?

@trescube trescube merged commit cbc7fc5 into master Oct 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@trescube trescube deleted the use-wof-label-when-available branch Oct 14, 2016

@trescube trescube removed the in progress label Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment