Remove parent id hierarchy support #157

Merged
merged 5 commits into from Oct 19, 2016

Conversation

Projects
None yet
2 participants
@trescube
Contributor

trescube commented Oct 17, 2016

parent_id hierarchy walking is grossly outdated. Fixes #156

@trescube trescube added this to the Who's on First milestone Oct 17, 2016

@trescube trescube self-assigned this Oct 17, 2016

@orangejulius

This comment has been minimized.

Show comment
Hide comment
@orangejulius

orangejulius Oct 17, 2016

Member

Woah, we were walking the whole hierarchy when there was one already calculated for us? I assume this was done because the hiearchies weren't great when we started using WOF (I also assume they're much better now). This definitely feels better, and is probably faster too! :shipit:

Member

orangejulius commented Oct 17, 2016

Woah, we were walking the whole hierarchy when there was one already calculated for us? I assume this was done because the hiearchies weren't great when we started using WOF (I also assume they're much better now). This definitely feels better, and is probably faster too! :shipit:

@trescube

This comment has been minimized.

Show comment
Hide comment
@trescube

trescube Oct 17, 2016

Contributor

When we first wrote the importer, we just went with walking up the hierarchy implied by wof:parent_id values. We finally worked out the kinks of using the wof:hierarchies so the wof:parent_id code was left in place though it wasn't being used.

Contributor

trescube commented Oct 17, 2016

When we first wrote the importer, we just went with walking up the hierarchy implied by wof:parent_id values. We finally worked out the kinks of using the wof:hierarchies so the wof:parent_id code was left in place though it wasn't being used.

@trescube trescube merged commit 100dbe2 into master Oct 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@trescube trescube deleted the remove-parent-id-hierarchy-support branch Oct 19, 2016

@trescube trescube removed the in review label Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment