Handle localadmin layer #53

Merged
merged 2 commits into from Jun 21, 2016

Conversation

Projects
None yet
2 participants
@orangejulius
Member

orangejulius commented Jun 15, 2016

Previously, locality records did not get looked up against localadmin, which caused missing admin info.

Conversely, localadmin records were looked up against all layers, including locality and neighbourhood, which isn't correct.

This pr is a subset of the changes from #50, with no unexpected side effects regarding abbreviations. It doesn't fix as many label issues though.

orangejulius added some commits Jun 15, 2016

Add localadmin to locality layer
It was missing previously.
Add localadmin level
Previously, localadmin records were getting admin info from all levels,
including locality and neighbourhood, which isn't right.

@orangejulius orangejulius self-assigned this Jun 15, 2016

@missinglink

This comment has been minimized.

Show comment
Hide comment
Member

missinglink commented Jun 20, 2016

👍

@orangejulius orangejulius merged commit 06f8356 into master Jun 21, 2016

2 of 3 checks passed

approvals/lgtm this commit is pending approval
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius removed the in review label Jun 21, 2016

@orangejulius orangejulius deleted the add_localadmin branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment