Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "src:alt_label" in preference to "src:geom" when available #13

Merged
merged 1 commit into from
May 2, 2020

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented May 2, 2020

PR to resolve issue outlined in whosonfirst-data/whosonfirst-data#1834

Use "src:alt_label" in preference to "src:geom" when available for geojson.source field in SQLite db.

I'm not quite sure what's preferable for the "source" column in the meta files so I kept them the same (using "src:geom") 🤷

related: pelias/docker#192

@missinglink missinglink merged commit f7a094b into master May 2, 2020
@missinglink missinglink deleted the sqlite_geom_src branch May 2, 2020 09:04
@missinglink
Copy link
Member Author

Files are being regenerated now and I can confirm the Canada issue is resolved.

stat -c '%y' whosonfirst-data-admin-ca-latest.db
2020-05-02 14:10:44.486517697 +0200

sqlite3 whosonfirst-data-admin-ca-latest.db 'SELECT id, source, is_alt FROM geojson WHERE id = 85633041'
85633041|whosonfirst|0
85633041|naturalearth-display-terrestrial-zoom6|1
85633041|naturalearth|1
85633041|quattroshapes|1
85633041|whosonfirst-reversegeo|1

They're generated alphabetically and it's only up to 'S', so it'll take a while longer before the new files are uploaded.

@missinglink
Copy link
Member Author

Assets have been uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant