Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pelican 4 #19

Closed
wants to merge 9 commits into from

Conversation

@Ecno92
Copy link
Collaborator

@Ecno92 Ecno92 commented Dec 30, 2018

Added support for Pelican 4. (before it raised a critical warning due to a key error)
Tests are working for both Pelican 3.7.1 as 4.0.1
https://travis-ci.org/Ecno92/image_process/builds/473609327

test_image_process.py Outdated Show resolved Hide resolved
Loading
@Ecno92
Copy link
Collaborator Author

@Ecno92 Ecno92 commented Jan 28, 2019

@patrickfournier could you maybe review again? Thanks!

Loading

MinchinWeb added a commit to MinchinWeb/minchin.pelican.plugins.image_process that referenced this issue Aug 6, 2019
@MinchinWeb
Copy link
Member

@MinchinWeb MinchinWeb commented Aug 19, 2019

@Ecno92 : I've been maintain my own fork, and ran into this same issue. Thanks for providing the solution!

Loading

@Ecno92
Copy link
Collaborator Author

@Ecno92 Ecno92 commented Aug 29, 2019

@MinchinWeb Thanks for your response and your efforts to keep maintaining this project using your own fork.

@patrickfournier What are your expectations regarding merging in open pull requests/maintaining this project?

Loading

@patrickfournier
Copy link
Collaborator

@patrickfournier patrickfournier commented Aug 30, 2019

@Ecno92 or anyone else: would you like to be added as a maintainer? I appreciate the efforts you all put on creating PRs, but I feel someone else would do a better job at keeping this project up to date.

Loading

@Ecno92
Copy link
Collaborator Author

@Ecno92 Ecno92 commented Sep 3, 2019

@patrickfournier Feel free to add me as an maintainer. For the short term I plan on working a little bit on my own website. So I may be able to help you as I probably will touch this extension as well.
For the long term I expect that I can not contribute to this project. However maybe someone else will show up to help. :-)

Loading

@patrickfournier
Copy link
Collaborator

@patrickfournier patrickfournier commented Sep 6, 2019

@Ecno92 Thanks for volunteering. I added you as a maintainer: https://github.com/whiskyechobravo/image_process/invitations

Loading

@Ecno92
Copy link
Collaborator Author

@Ecno92 Ecno92 commented Oct 29, 2019

Most recent master includes the fixes for supporting pelican 4

Loading

@Ecno92 Ecno92 closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants