Skip to content
This repository

oauth-plugin 0.4.1 fails tests with ruby 1.8.7 #127

Open
graaff opened this Issue · 0 comments

1 participant

Hans de Graaff
Hans de Graaff

With ruby 1.8.7 (2012-06-29 patchlevel 370) [x86_64-linux] I'm getting a few test failures. These all looks like innocent manifestations of the now-random hash ordering in newer patch levels of ruby 1.8.7.

  1) OAuth::Provider::Authorizer Authorization code should issue code should include state
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?code=secret%20auth%20code&state=customer%20id"
       expected: "http://mysite.com/callback?code=secret%20auth%20code&state=customer%20id"
            got: "http://mysite.com/callback?state=customer%20id&code=secret%20auth%20code" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:49

  2) OAuth::Provider::Authorizer user does not authorize should send error with state and query params in callback
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?this=one&error=access_denied&state=my%20customer"
       expected: "http://mysite.com/callback?this=one&error=access_denied&state=my%20customer"
            got: "http://mysite.com/callback?this=one&state=my%20customer&error=access_denied" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:92

  3) OAuth::Provider::Authorizer user does not authorize should send error with state and query params in callback
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?this=one#error=access_denied&state=my%20customer"
       expected: "http://mysite.com/callback?this=one#error=access_denied&state=my%20customer"
            got: "http://mysite.com/callback?this=one#state=my%20customer&error=access_denied" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.