Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Encoder.CompactComments to omit extra new line #541

Merged
merged 1 commit into from May 12, 2021

Conversation

@Felixoid
Copy link
Contributor

@Felixoid Felixoid commented May 11, 2021

Issue: #540

The extra newline before each commit is omitted when Encoder.CompactComments(true) is used.

I am not 100% sure about the docstring, so very open to feedback.

@pelletier
Copy link
Owner

@pelletier pelletier commented May 12, 2021

Looks good to me, thank you!

@pelletier pelletier merged commit d083470 into pelletier:master May 12, 2021
17 checks passed
17 checks passed
@github-actions
Analyze (go)
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@azure-pipelines
pelletier.go-toml Build #20210511.4 succeeded
Details
@azure-pipelines
pelletier.go-toml (Build Docker image Build) Build Docker image Build succeeded
Details
@azure-pipelines
pelletier.go-toml (Build binaries Build binary darwin_amd64) Build binaries Build binary darwin_amd64 succeeded
Details
@azure-pipelines
pelletier.go-toml (Build binaries Build binary linux_amd64) Build binaries Build binary linux_amd64 succeeded
Details
@azure-pipelines
pelletier.go-toml (Build binaries Build binary windows_amd64) Build binaries Build binary windows_amd64 succeeded
Details
@azure-pipelines
pelletier.go-toml (Build binaries manifest Build binaries manifest) Build binaries manifest Build binaries manifest succeeded
Details
@azure-pipelines
pelletier.go-toml (Check benchmark) Check benchmark succeeded
Details
@azure-pipelines
pelletier.go-toml (Check coverage) Check coverage succeeded
Details
@azure-pipelines
pelletier.go-toml (Check fmt) Check fmt succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests linux 1.15) Check unit tests linux 1.15 succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests linux 1.16) Check unit tests linux 1.16 succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests mac 1.15) Check unit tests mac 1.15 succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests mac 1.16) Check unit tests mac 1.16 succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests windows 1.15) Check unit tests windows 1.15 succeeded
Details
@azure-pipelines
pelletier.go-toml (Check unit tests windows 1.16) Check unit tests windows 1.16 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants