Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smudge Tool bug: Can't undo smudges. #1004

Closed
Trolltass opened this issue Jun 25, 2018 · 5 comments
Closed

Smudge Tool bug: Can't undo smudges. #1004

Trolltass opened this issue Jun 25, 2018 · 5 comments

Comments

@Trolltass
Copy link

@Trolltass Trolltass commented Jun 25, 2018

If I use the smudge tool i can't undo it. Very annoying :(

@Trolltass Trolltass changed the title Smudge Tool bug Smudge Tool bug: Can't undo smudges. Jun 25, 2018
@Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Jun 25, 2018

@Trolltass Hi. Yes the smudge tool is a work in progress so don't use it for now. If you need that kind of effect use krita or GIMP to smudge the drawings and bring them back into pencil2D. You can copy paste back and forth between pencil2d and Krita without issues, haven't tried GIMP though.

Also this bug has been reported before, so we kindly ask that next time use the search function to see if the problem you have has already been reported.

Developers are looking to integrate a library that allows better use of brushes so the smudge tool will only be improved once this library becomes integrated, we hope that will happen before summer 2019, but I can't give you an ETA since we're all volunteers and work time depends on our own schedules.

@Kaikogf
Copy link

@Kaikogf Kaikogf commented Jun 16, 2020

@Jose-Moreno
This issue is already fixed (it is working fine with the last code from 14th of Jun) 👍
You may close it

@Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Jun 20, 2020

@Kaikogf I don't know exactly what is fixed for you, however I'm using June 17th nightly and I still can't undo neither smudge nor blur by using shortcuts or the menu action commands.

Are you sure you're not using the MyPaint version instead? 🤔

I'm sorry to say that this issue will only be potentially fixed once @CandyFace implements the Undo/Redo system he was working on before actively developing the MyPaint branch 🖌️

@Kaikogf
Copy link

@Kaikogf Kaikogf commented Jun 25, 2020

More than words
👍

smudge

Using the shortcut for the smudge tool. Built the last code from jun 17th, wind 10 pro

@Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Jul 30, 2020

@Kaikogf Sorry it took me so long. Ok It seems that to me it works half way. What happens is:

  1. I create a single brush stroke
  2. Use the smudge tool
  3. Undo -> In here the program undoes the operation but visually I still see the smudge
  4. I undo again and the stroke is undone along the smudge (+ white artifacts)
  5. I redo once and the stroke is redone with the smudge (+white artifacts)

It seems that the smudge tool events are getting merged with the drawing tool first stroke, after that you can smudge and undo just like your GIF. So there's still a bug due to unwanted behavior as I expect each smudge stroke to be acknowledged as an independent stroke in order to be undone.

This will be fixed with the new undo/redo system once CandyFace finalizes the finishing touches and includes the new features that require undo/redo, so I recommend not closing this just yet.

@Jose-Moreno Jose-Moreno added this to Medium priority in Bug Fix Priority Aug 30, 2020
@Jose-Moreno Jose-Moreno linked a pull request that will close this issue Oct 24, 2020
@J5lx J5lx closed this in 435ff70 Oct 24, 2020
Bug Fix Priority automation moved this from Medium priority to Closed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Fix Priority
  
Closed
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants