Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement individual division lines for the grid system #1066

Closed
Jose-Moreno opened this Issue Sep 30, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Sep 30, 2018

Issue Summary

Implement independent grid / reticule division separation. This would allow the individual control of the grid / reticule horizontal (along the Y-axis) and vertical (along the X-axis) separation lines to create both uniform and non-uniform quadangular tiles that would correctly adapt to the aspect ratio of any given canvas size.

It's proposed that this setting occupies the same space on the preferences.

This will also help to implement further down the line a reactive field chart + studio templates that the animator can adapt according to their shot specifications.

@davidlamhauge

This comment has been minimized.

Copy link
Contributor

davidlamhauge commented Sep 30, 2018

I would like to work on this issue.
I have ideas on how this should be implemented.

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Oct 5, 2018

@davidlamhauge Thank you. Just tried it out and it works correctly on Version: 0.6.2
commit: ecbe853
date: 2018-10-05_13:12:56
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

One thing though, on the last version users could have a grid tile as small as a 1:1-pixel unit (this is was an intentional consideration for pixel art animators). Now it seems X and Y values are limited to 10 and it won't go lower than that. If possible please let the grid X and Y values go as low as 1-pixel. Other than that everything works great.

Edit: After testing a bit more you can go below 10 pixels, but not below 5 pixels using the spinnerboxes.

I'll close this issue as the main topic (Implementing individual properties for the grid) has been solved. 🙂

@Jose-Moreno Jose-Moreno closed this Oct 5, 2018

@davidlamhauge

This comment has been minimized.

Copy link
Contributor

davidlamhauge commented Oct 6, 2018

@Jose-Moreno If a 1:1-pixel unit is asked for, it is easy to change.
To me, it made no sense to have a grid smaller than 5x5 so it set this limit, thinking that no one would ever go that low 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.