Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tif/tiff import and export #1068

Closed
scribblemaniac opened this Issue Oct 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@scribblemaniac
Copy link
Member

scribblemaniac commented Oct 1, 2018

We used to have support for TIFF import and export that implemented in the same way as png, bmp, and jpg, using Qt's built-in functionality. Unfortunately it was not working so it was removed in #948.

Unlike some of the more common formats, tiff is not in the core Qt gui, but is rather a plugin (maintained by Qt). I'm pretty sure the issue was that this plugin wasn't getting loaded properly. Solving this will hopeful be enough to fix the issue and reinclude this format. For more information about Qt image format plugins, see here: https://doc.qt.io/qt-5/qtimageformats-index.html

@Jose-Moreno Jose-Moreno added this to the hacktoberfest milestone Oct 1, 2018

chchwy added a commit that referenced this issue Oct 5, 2018

Merge pull request #1088 from nevdokimof/add-tiff-support
#1068 added support for tiff import/export
@Jose-Moreno

This comment has been minimized.

Copy link
Member

Jose-Moreno commented Oct 5, 2018

@scribblemaniac I have tested this in Version: 0.6.2
commit: ecbe853
date: 2018-10-05_13:12:56
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

TIFF Import / Export works as expected. I recommend closing this issue if you deem it proper.
Thanks to @nevdokimof for the implementation and heeding the reviews 🙂

Note: I'll leave this comment as something I'd like to see later on regarding this format, and for which I'll make a separate issue. One of the qualities of TIFF images is that it can store layers. If possible it would be great that the TIFF export from Pencil2D would allow it to store at least bitmap layer information in the tiff files. It would be interesting as well to consider the vector layer information to be included, however these would have to be rasterized on export and converted into bitmap layers for that to work.

@scribblemaniac

This comment has been minimized.

Copy link
Member Author

scribblemaniac commented Oct 5, 2018

Yes this should have been closed automatically, but I guess Github didn't want to cooperate. 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.