Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate timeline "frame size" slider widget from preferences to timeline #1074

Closed
Jose-Moreno opened this Issue Oct 1, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Oct 1, 2018

Issue Summary

Changing the timeline frame container width is currently done through the preferences with a slider. While this is interactive, it's a bit buried and the user has no idea it exists. It would also be more efficient if we managed to use the widget a slider to act sort of like a "timeline magnification slider" but directly on the timeline instead of staying in the preferences.

(Pending: Add mockup, immediate reference After Effects magnifying slider)

Along with this I'd like to ask that the maximum width of the frames would also be increased. Wider keyframe drawing containers would help accommodate future thumbnails as seen in the timeline re-write proposal.

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented Oct 3, 2018

image
In my mockup I referred to it as zoom but well yeah the idea is the same. It's about making the frame container bigger or smaller.

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Oct 3, 2018

@CandyFace Yes it is! I was just separating a lot of these piled up issues from the feature tracker and to avoid confusion I also labeled it with the "timeline" label to indicate that all of these are related. I forgot to reference the timeline re-write issue though 😅
Aside form that maybe I should put them into a "timeline" milestone as well? 🤔 What do you think?

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented Oct 3, 2018

I think it's nice to have it as a separate issue :) and adding it to a timeline milestone good too

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Mar 17, 2019

Fixed by #1121
We might have to revisit the code once the timeline is rewritten, and it can use some enhancements in the UI/UX front (e.g it's very hard to select super thin frames) but for now it works as intended. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.