Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.gpl file palette importer miss-handling whitespace and names #1094

Closed
Jose-Moreno opened this Issue Oct 5, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Oct 5, 2018

Issue Summary

I've been testing the gpl import-export in the case of importing actual gpl's that were exported properly form Pencil2D it will work, however many of the GIMP palettes have no names for colors, so if you try to use them on import Pencil2D it will start thinking the last RGB value of a color is it's name, and it will change the whole palette hue, lightness and saturation. Not fun if we assume many people will attempt to use GIMP and or Krita palettes without names.

Pencil2D should look to identify four value lists as a full color, and that if the fourth value is an empty string it should be given an automatic name like Color1, and subsequently each "unnamed" color will be named like this afterwards.

Expected Results

I expect color palettes are not changed when being imported into pencil2d. As a user, If I didn't named it, I don't care about the name.

Video or Image Reference

The GIMP 2.8 gpl format palette for testing import issue
Firecode.gpl.zip
This palette is made of warm colors. When you import it you will get green colors and you'll see the color name is made of the last RGB value.

Steps to reproduce

  1. Open Pencil2D
  2. File > Import > Palette > Change palette type to *.GPL
  3. Import the test palette. Notice the hue, saturation & lightness shift.

System Information

  • Pencil2D Version:

Version: 0.6.2
commit: ecbe853
date: 2018-10-05_13:12:56
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

@Jose-Moreno Jose-Moreno changed the title GIMP gpl palette import miss-handling whitespace and names *.gpl file palette importer miss-handling whitespace and names Oct 5, 2018

@CandyFace CandyFace assigned CandyFace and unassigned CandyFace Oct 5, 2018

@chchwy chchwy added the hacktoberfest label Oct 7, 2018

chchwy added a commit that referenced this issue Oct 7, 2018

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Oct 9, 2018

I can confirm this works now. Colors without names are imported with an automatically generated name + a suffix number appended. Closing 🙂

@Jose-Moreno Jose-Moreno closed this Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.