Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection Flipping is not undoable / redoable #1098

Closed
Jose-Moreno opened this issue Oct 6, 2018 · 2 comments
Closed

Selection Flipping is not undoable / redoable #1098

Jose-Moreno opened this issue Oct 6, 2018 · 2 comments

Comments

@Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Oct 6, 2018

Issue Summary

A very simple user experience issue / bug. when flipping a selection either on the X or Y axis, this command is not undo-able / redo-able.

Expected Results

Due to the nature of art, most if not all drastic changes in a drawing should be undoable. Flipping a drawing changes it's direction and sometimes artists try to find the best way to present them.

Note: This is not a critical bug by any means, you can flip the drawing again instead of undoing, but from a functionality standpoint all of these commands should be undo-able.

Steps to reproduce

  1. Draw something
  2. Enclose it with the selection tool
  3. Go to Edit > Selection > Flip X / Y
  4. Press Ctrl + Z or go to Edit > Undo

System Information

  • Pencil2D Version:

Version: 0.6.2
commit: ecbe853
date: 2018-10-05_13:12:56
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

@chchwy
Copy link
Member

@chchwy chchwy commented Oct 7, 2018

will take a look after merging the Undo Refactoring PR

@Jose-Moreno
Copy link
Member Author

@Jose-Moreno Jose-Moreno commented Aug 16, 2020

[2020] Testing on 0.6.5 Currently it seems you can undo the selection flipping, but it's still a bit buggy. After flipping the selection, if you immediately undo while the selection marquee still enabled this will delete from view the drawing inside the selection.

I assume that since it also removes the selection, anything that it's inside is being treated as part of the selection by the Canvas Painter.

So the drawing disappears, but if you redo again you'll see the drawing reappear again and the flip is undone, also a marquee selection appears along the drawing even though it should be treated as a separate event (it should required an extra undo/redo step).

@Jose-Moreno Jose-Moreno added this to Medium Priority in Enhancement Priority Aug 31, 2020
@Jose-Moreno Jose-Moreno linked a pull request that will close this issue Oct 24, 2020
@J5lx J5lx closed this in #1486 Oct 24, 2020
@J5lx J5lx closed this in aadd0aa Oct 24, 2020
Enhancement Priority automation moved this from Medium Priority to Closed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants