Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range input boxes come activated even when the checkbox is not ticked during application initialization #1101

Closed
Jose-Moreno opened this Issue Oct 6, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Oct 6, 2018

Issue Summary

As noted by @davidlamhauge (Thank you!)
The range feature numerical input spinboxes are turned ON when the program starts, and only resume their normal behaviour after deactivating the range checkbox once.

I'd say it's not wanted behaviour. It really depends on how people approach the feature itself, however it may be more logical and clear to the user to only enable the spinboxes when the checkbox is turned and deactivate them when the checkbox is not ticked.

Steps to reproduce

  1. Open Pencil2D
  2. Note the range numerical input start / end spin boxes are active
  3. Turn the range function ON by ticking the checkbox
  4. Turn the range fucntion OFF by ticking the checkbox. Notice that the input boxes are greyed out.

System Information

  • Pencil2D Version:

Version: 0.6.2
commit: ecbe853
date: 2018-10-05_13:12:56
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

@davidlamhauge

This comment has been minimized.

Copy link
Contributor

davidlamhauge commented Oct 6, 2018

IF we agree upon this as an unwanted behavior, then I would like to claim it.
Maybe some new potential developer should have it, since it is an easy fix.

@scribblemaniac

This comment has been minimized.

Copy link
Member

scribblemaniac commented Oct 6, 2018

I agree this is unwanted behavior. It should be consistent one way or another.

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented Oct 7, 2018

Agreed

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Oct 12, 2018

This has been confirmed to be fixed in Version: 0.6.2
commit: 6471882
date: 2018-10-12_11:17:33
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

Closing this issue. Thank you everyone for discussing and David for implementing it.

@Jose-Moreno Jose-Moreno modified the milestones: 0.6.3, hacktoberfest Oct 12, 2018

@chchwy chchwy modified the milestones: hacktoberfest, 0.6.3 Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.