Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing Selection Flip X / Y will delete the drawing #1120

Closed
Jose-Moreno opened this issue Nov 1, 2018 · 1 comment · Fixed by #1486
Closed

Undoing Selection Flip X / Y will delete the drawing #1120

Jose-Moreno opened this issue Nov 1, 2018 · 1 comment · Fixed by #1486

Comments

@Jose-Moreno
Copy link
Member

Issue Summary

Testing the program I forgot to report this. Basically if you select an area and use the Selection Flip X / Y function and then undo that operation, the drawing will be deleted. You can redo the drawing being deleted to the flipped state though.

Current workaround is flipping the selection again in the same axis

Expected Results

Flipping Selection should be un-doable /re-doable

Steps to reproduce

  1. Draw something
  2. Press CTRL + A or Create a Box Selection over the strokes
  3. Go to Edit > Selection > Flip x/y
  4. Remove selection. You can keep it too, it doesn't matter.
  5. Press CTRL + Z. Drawing disappears.

System Information

  • Pencil2D Version:
    Version: 0.6.2
    commit: 6471882
    date: 2018-10-12_11:17:33
    Development build
    Operating System: Windows 7 SP 1 (6.1)
    CPU Architecture: x86_64
@MrStevns
Copy link
Member

I'll check if I can reproduce this in the undo-redo rewrite branch.

@MrStevns MrStevns self-assigned this Dec 14, 2018
@Jose-Moreno Jose-Moreno added this to Medium priority in Bug Fix Priority Aug 30, 2020
@Jose-Moreno Jose-Moreno linked a pull request Oct 24, 2020 that will close this issue
@J5lx J5lx closed this as completed in aadd0aa Oct 24, 2020
Bug Fix Priority automation moved this from Medium priority to Closed Oct 24, 2020
@Jose-Moreno Jose-Moreno added this to the 0.6.6 milestone Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Fix Priority
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants