Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas zoom factor abrupt change disrupts navigation workflow #1169

Closed
Jose-Moreno opened this issue Feb 5, 2019 · 5 comments
Closed

Canvas zoom factor abrupt change disrupts navigation workflow #1169

Jose-Moreno opened this issue Feb 5, 2019 · 5 comments
Labels
Milestone

Comments

@Jose-Moreno
Copy link
Member

Issue Summary

A new issue related to navigation on the canvas, specifically the canvas zoom functionality. Currently there is an input gesture to activate the zoom where clicking & dragging upwards zooms in and dragging downwards zooms in. The issue occurs when you have previously zoomed in, and then click to zoom out the factor will change abruptly. Same happens when you zoom out and then zoom in.

Expected Results

Previous zooming operations should not affect the zoom factor abruptly. Zooming should always interpolate from the current zoom factor to the next regardless of the current and final values.

Video or Image Reference

https://youtu.be/AB9jfLrHloo

Steps to reproduce

  1. Open Pencil2D
  2. Drawing something to have as a reference point to see.
  3. Zoom out (click and drag downwards)
  4. Zoom in (click and drag upwards)
  5. Notice the drastic change in zoom factor.

System Information

Version: 0.6.2
commit: fe450b7
date: 2019-02-05_13:58:04
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

@Jose-Moreno Jose-Moreno added the Bug label Feb 5, 2019
@chchwy chchwy added this to the 0.6.3 milestone Feb 19, 2019
@chchwy chchwy closed this as completed in 9fba8ca Feb 19, 2019
@chchwy
Copy link
Member

chchwy commented Feb 19, 2019

Please test with the 19 Feb nightly build.

@Jose-Moreno
Copy link
Member Author

Can confirm the bug is gone. It seems dragging speed does affect zoom factor but it is mostly noticeable when dragging upwards to zoom out but that's not a bug, rather a user experience thing. Right now zooming in/out behaves in a responsive manner. Thanks a lot!

@MrStevns
Copy link
Member

MrStevns commented Feb 20, 2019

The zoom functionality should not be affected by dragging using the hand tool, I'd consider that a bug.

@scribblemaniac
Copy link
Member

@candyface I would assume he means dragging with control+hand tool which is a shortcut for zooming (I only just recently learned about this myself).

@MrStevns
Copy link
Member

MrStevns commented Feb 20, 2019

@scribblemaniac Ah yes of course, I completely forgot about that feature. In that case disregard my last comment :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants