Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High feathering values do not allow pixel application on canvas #1193

Closed
Jose-Moreno opened this issue Mar 18, 2019 · 1 comment
Closed

High feathering values do not allow pixel application on canvas #1193

Jose-Moreno opened this issue Mar 18, 2019 · 1 comment

Comments

@Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Mar 18, 2019

Issue Summary

Any feathering value above 96 (tested with Qt by modifying ui files) will clamp the feather and not draw any pixels at all. This affects particularly the Brush Tool as it is the only active tool that paints with variable feathering but this is a global issue, so the Pencil tool, the Smudge tool or any other tool that would be set to sue feathering would suffer from this issue.

Expected Results

I mentioned before a value fo 200 might be good, but what I meant was that a value that amtched the maximum SIZE value, would work, however it seems the calculations say otherwise.

On Discord it was suggested to clamp the feathering values from 0 to 100, but the maximum feathering value should never stop the user from painting, at most it will give a very faint and smoothed out paint feel.

Steps to reproduce

  1. Open Pencil2D
  2. Select the brush tool and move the slider to the right most edge. The input box will say 80, but this is another bug reported here: #1194
  3. Try to draw anything.
  4. Move the slider to the left little by little until you can draw and compare.

System Information

  • Pencil2D Version:
    Version: 0.6.3
    Operating System: Windows 7 SP 1 (6.1)
    CPU Architecture: x86_64
@davidlamhauge
Copy link
Contributor

@davidlamhauge davidlamhauge commented Sep 19, 2019

I have looked into this, and it seems as if feather values from 99.6 and up, will prevent any changes to the canvas.
I don't know how feathering is working under the hood, but it seems logical to set maximum to 100 (or 99), since we don't want frustrated users.
I have noticed that the opacity value, when you use the feather, is 0.5 or lower! My guess is that this is the key to the problem, but I have no clue what happens.
Is it possible that @scribblemaniac or maybe @J5lx could explain how the feather feature works?

@scribblemaniac scribblemaniac added this to the Hacktoberfest 2019 milestone Oct 3, 2019
CandyFace added a commit that referenced this issue Oct 3, 2019
#1193 Changing feather range to 1-99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants