Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover stroke end on canvas update under certain conditions #1196

Open
Jose-Moreno opened this Issue Mar 18, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Mar 18, 2019

Issue Summary

There is currently a leftover brush stroke "line terminator / end" pending canvas update when disabling pressure checkbox for the following tools:

  • Pen tool
  • Brush tool
  • Pencil tool
  • Eraser (only visible if you erase outside the camera bounds)

The leftover appears when using the "Clear Frame" action, creating a new frame or deleting the current frame. This only happens when using the stylus.

Workaround is "forcibly" updating the canvas by using the eraser and clicking on canvas with it.

Expected Results

Such stroke ends should not be visible after updating the canvas when erasing or performing keyframe operations.

@CandyFace performed recently a PR Fix on #1181 that seems related to this, since the original issue was much broader (it appeared regardless of pressure but using stylus) but this case appears to be very particular (disabling the pressure checkbox only activates the bug)

Video or Image Reference

Making a stroke using Pen tool, no pressure
image

Using the "Clear Frame" action to clear the canvas
image

Steps to reproduce

  1. Open Pencil2D
  2. Select any drawing tool with a pressure checkbox (I used Pen tool in my test)
  3. Make a reference stroke with the pressure checkbox enabled.
  4. Delete the reference stroke using the Clear Frame command or make a new keyframe
  5. Next disable the pressure checkbox on the tool
  6. Draw a new line normally
  7. Clear the frame or create a new keyframe. Compare the results

System Information

  • Pencil2D Version:

Version: 0.6.3
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.