Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing with polyline on top of another vector stroke causes artifacts #1433

Closed
MrStevns opened this issue Aug 19, 2020 · 4 comments · Fixed by #1434
Closed

Drawing with polyline on top of another vector stroke causes artifacts #1433

MrStevns opened this issue Aug 19, 2020 · 4 comments · Fixed by #1434

Comments

@MrStevns
Copy link
Member

MrStevns commented Aug 19, 2020

Issue Summary

While working on getting vector useable again for the mypaint branch, I noticed that the polyline is broken when painting on top of another stroke.

I already have a fix for this, I'm just creating the issue so we have something to tie the bug to.

Actual Results

While artifacts appear whereever the stroke touches or it's update area.

Expected Results

No artifacts should appear.

Video or Image Reference

vector bug

Steps to reproduce

  1. Draw a vector stroke
  2. Draw a polyline stroke on top

System Information

Development Build Aug 19 2020 (master)

Operating System: macOS Mojave (10.14)
CPU Architecture: x86_64
Qt Version: 5.15.0

  • Operating System:
    Mac OS 10.14.5
@Jose-Moreno
Copy link
Member

Jose-Moreno commented Aug 19, 2020

@candyface I'm having an issue with the polyline tool where undoing the line will not update the canvas painter. After looking at this, do you think that issue is related to this one? or should I report it as an individual issue? I'm asking mostly because I saw your fix involves the canvas painter rendering.

The bug I'm having I can reproduce like this:

  1. Draw a complete stroke with the polyline in the bitmap layer
  2. Undo the stroke. You'll notice however that the stroke is still visible
  3. Create a new stroke and you'll notice the old one will disappear (the canvas painter render is updated I suppose)

@scribblemaniac
Copy link
Member

scribblemaniac commented Aug 19, 2020

@Jose-Moreno This is a vector-only issue and fix, so the issue which you mentioned which affects the bitmap layer is something else and should be reported separately.

@MrStevns
Copy link
Member Author

MrStevns commented Aug 19, 2020

Indeed this pr touches only vector painting logic, what you're describing @Jose-Moreno is another problem that needs to be fixed.

@Jose-Moreno
Copy link
Member

Jose-Moreno commented Aug 19, 2020

@scribblemaniac @candyface Thank you for the explanation 🙇 I will report it separately then 👍

@chchwy chchwy added this to the 0.6.6 milestone Aug 25, 2020
@Jose-Moreno Jose-Moreno added this to Needs triage in Bug Fix Priority via automation Sep 18, 2020
@Jose-Moreno Jose-Moreno moved this from Needs triage to Closed in Bug Fix Priority Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Fix Priority
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants