Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas missing update when undoing strokes created with polyline tool. #1435

Closed
Jose-Moreno opened this issue Aug 20, 2020 · 0 comments · Fixed by #1476
Closed

Canvas missing update when undoing strokes created with polyline tool. #1435

Jose-Moreno opened this issue Aug 20, 2020 · 0 comments · Fixed by #1476

Comments

@Jose-Moreno
Copy link
Member

Jose-Moreno commented Aug 20, 2020

Issue Summary

When drawing any given line with the polyline tool, undoing the stroke will result in the buffer not being cleaned / updated from the stroke until the polyline tool is used to draw again.

The after effects of the buffer not being updated (or the stroke "event" not being added?) hold remarkable resemblance to the problem from #1196 and fixing this could potentially help fixing that one which seems to be more elusive as you have to jerk your stylus in a certain way while the stroke is being computed, in order to reproduce.

Expected Results

Creating any kind of line with any drawing tool should never become fixated to the canvas as this can and will cause confusion in the end user.

Video or Image Reference

https://youtu.be/onnZfHpHNWw

Steps to reproduce

  1. Create a new file
  2. Pick the polyline tool and draw a single "complete" stroke (that is, click, move the mouse and double click to finalize the stroke drawing mode)
  3. Undo
  4. Notice that the stroke is still present
  5. Using the polyline tool draw a new stroke away from the previous one click on the canvas once without moving the mouse. Nothing happens. Now move the mouse slightly and you'll notice that the previous stroke disappears as soon as move the pointer.

System Information

  • Pencil2D Version:

Version: 0.6.5

commit: 50a0c7c
date: 2020-08-01_01:32:15

Operating System: Windows 10 (10.0)
CPU Architecture: x86_64
Qt Version: 5.12.9

@chchwy chchwy added this to the 0.6.6 milestone Aug 25, 2020
@Jose-Moreno Jose-Moreno added this to Needs triage in Bug Fix Priority Aug 30, 2020
@Jose-Moreno Jose-Moreno moved this from Needs triage to High priority in Bug Fix Priority Aug 30, 2020
MrStevns added a commit to MrStevns/pencil that referenced this issue Sep 19, 2020
Bug Fix Priority automation moved this from High priority to Closed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Fix Priority
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants