Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] stabilization function create artifacts on drawing strokes #677

Closed
Jose-Moreno opened this Issue May 26, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@Jose-Moreno
Copy link
Member

Jose-Moreno commented May 26, 2017

--Issue Summary--

When drawing with any tool that has pressure sensitivity, the strokes are leaving a full pressure dab at the end of the stroke.

--Actual Results

You get lines that get a dot drawn on the last portion of the stroke

At first appears to happen randomly but it seems to be tied to the speed of the stroke being drawn as well as the stabilization feature. When you set the stabilization to level 3 (third dot) every line finishes with a full pressure dab when drawing "fast". But if you draw rather slow this does not happen.

Note: Other users have reported this issue as well on the forum

--Expected Results--

Drawing and making strokes at a fast speed should not prove visual artifacts.

--Video or Image Reference--

image

--Steps to reproduce--

  1. Open Pencil2D
  2. Select Pen or Pencil tool
  3. Draw fast, as if you were sketching on paper.
  4. Press radial button to enable stabilization level 3
  5. Draw again.

--System Information--

  • Pencil2D Version:

Pencil2D Nightly Build May 20 2017

  • Operating System:

Windows 7 Ultimate

  • RAM Size:
  • CPU:
  • Graphics Tablet:

Wacom Intuos Pro 5

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented May 27, 2017

I can't reproduce the dabbing with the Pencil tool if pressure is on, it does happen when it is off though and indeed there is still pressure too even though it's off. It happens no matter what with the pen... strange.

I'll take a look at it.

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented May 27, 2017

Alright I've located the problems, fix coming up asap ;)

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Nov 23, 2018

This bug is back in November 13th 2018 build. The repro steps are the same (even changing the stabilizer). The computer & tablet specs are the same. This wasn't happening in October 14th 2018 build.

@Jose-Moreno Jose-Moreno reopened this Nov 23, 2018

@scribblemaniac

This comment has been minimized.

Copy link
Member

scribblemaniac commented Nov 23, 2018

Almost certainly reintroduced from #1059.

@scribblemaniac

This comment has been minimized.

Copy link
Member

scribblemaniac commented Dec 4, 2018

@Jose-Moreno has helped us do some debugging work on this. Here is the most detailed log he provided from one of these reed strokes:

fn: setCurrentTool  call: setCursor() current tool "Eyedropper"
fn: setCurrentTool  call: setCursor() current tool "Pencil"
adjustPressure 0.447703 false
tabletPressEvent 0.447703
mousePressEvent
adjustPressure 0.468231 false
tabletMoveEvent 0.468231
mouseMoveEvent
adjustPressure 0.486804 false
tabletMoveEvent 0.486804
mouseMoveEvent
adjustPressure 0.513196 false
tabletMoveEvent 0.513196
mouseMoveEvent
adjustPressure 0.517107 false
tabletMoveEvent 0.517107
mouseMoveEvent
adjustPressure 0.521994 false
tabletMoveEvent 0.521994
mouseMoveEvent
adjustPressure 0.511241 false
tabletMoveEvent 0.511241
mouseMoveEvent
adjustPressure 0.410557 false
tabletMoveEvent 0.410557
mouseMoveEvent
adjustPressure 0.177908 false
tabletMoveEvent 0.177908
mouseMoveEvent
adjustPressure 0 false
tabletReleaseEvent 0
mouseReleaseEvent
fn: setCurrentTool  call: setCursor() current tool "Eyedropper"
fn: setCurrentTool  call: setCursor() current tool "Pencil"

Our current theory is that the issue is caused by the mouse events which definitely should not be there. This behavior is consistent with this bug reported to Qt. This appears to be Windows 7 specific and fixed in Qt 5.12 which will be released in a few days. If that fails to fix the issue we will have to look into other options. These including ignoring mouse events if the tablet is active/just completed, or setting Qt::AA_SynthesizeMouseForUnhandledTabletEvents to false.

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Dec 11, 2018

Will be working on this issue in the next few days.

@Jose-Moreno

This comment has been minimized.

Copy link
Member Author

Jose-Moreno commented Feb 5, 2019

@chchwy @CandyFace Ok I was testing some quick drawing and overall I think #1155 improved the drawing feel by a lot.

I incidentally found a minor issue when double clicking / tapping and moving but I don't see it as a critical issue since it is very hard to get by, but just wanted to let you know.

The issue at hand doesn't create a stroke like before but it does create a single dot with the last recorded alpha pressure. To reproduce it you have to explicitly double tap / click with the stylus a lot, it also has to be done super fast (~100ms?), almost as if you were trying to do some kind of "pointillism".

I'll share a video later as an edit to this comment just to document it thoroughly in case there's a way to fix it completely in a future version. Thanks! 😄

@Jose-Moreno Jose-Moreno referenced this issue Feb 26, 2019

Open

Ubuntu 18.10 Appimage Issues #1185

1 of 6 tasks complete

@scribblemaniac scribblemaniac reopened this Mar 1, 2019

@chchwy chchwy closed this in #1188 Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.