New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES] Making changes to the UserInterface Panels some changes will not be saved when restarting Pencil #744

Closed
Kaikogf opened this Issue Aug 28, 2017 · 15 comments

Comments

Projects
None yet
4 participants
@Kaikogf

Kaikogf commented Aug 28, 2017

--Issue Summary--

I have played with some panels on the User Interface, and most of them can be changed its size and position on the canvas.
This is just explaining what I got and hopefully it will show some inconsistencies on most of the Panels and even in some of the options inside them.

None of the following situations are an Issue per si, but I believe it is worth to mention.

Panels attached to its default location:
Changing the WIDTH of any panel [Color wheel, Color Palette, Display, Tools/Options] will remain saved when restarting Pencil2D
When changing the HEIGHT of the panels, the DISPLAY Panel will be the only one to remain saved when restarting Pencil2D

Panels detached to its default location:
Changing the Width or Height of any panel will remain saved when restating Pencil2D

Changes inside Panels:
Color Palette. Changing the presentation of the swatches will not be saved when restarting Pencil2D
Color Wheel. Changing RGB to HSV will not be saved when restarting Pencil2D. Also when changing colors it will bring BLACK as default
Tools. The Pencil tool will always be active when restarting Pencil2D, even when selecting another tool

--Expected Results--

Any change on the width or Height of any Panel should be saved when opening Pencil2D next time. The same goes to any modification inside the Panels meaning for instance when selecting the BRUSH tool as a preference tool will allow to restart Pencil2D with this tool already selected

I think this is the way to go
;)
👍

--System Information--

  • Pencil2D Version:
    Last build 27August2017

  • Operating System:
    Windows 8.1 x 64bits

  • RAM Size:
    32GB

  • Graphics Tablet:
    HUION GT185 HD

@CandyFace CandyFace added the bug label Aug 28, 2017

@Kaikogf

This comment has been minimized.

Kaikogf commented Aug 31, 2017

I forgot to mention that the same thing happens when resizing the camera to a different default size, it will not be saved.
:(

@Kaikogf

This comment has been minimized.

Kaikogf commented Nov 7, 2017

A similar behaviour from Nightly Build Nov 7 2017

Selecting a different "Interpolation feature" (on the Option's panel) will not be saved when restarting Pencil2D

@scribblemaniac

This comment has been minimized.

Contributor

scribblemaniac commented Nov 7, 2017

The panel layout is saving fine for me, including the height of the other panels. Can you provide some specific steps to replicate?

As for the changes within panels, I agree most of these should be saved, but it would be better if we did that after refactoring the Preferences module. I don't think the starting color should be saved though, and I can't think of any other programs which do that either.

@Kaikogf

This comment has been minimized.

Kaikogf commented Nov 8, 2017

Do you mean the starting colour to be always Black? I agree. I just mention that the black colour was used as default starting colour

My last comment was referring to changes within the Options 's panel: the selection made on the new bar "No Interpolation or Simple Line Interpolation or Strong Line Interpolation" will not be saved when restarting Pencil2D. Meaning that when selecting Strong Line Interpolation for instance and restarting Pencil2D it will bring back the No Interpolation option.

Thanks

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Jun 16, 2018

@Kaikogf Can you test if this issue still happens for you on the latest development build? also, as for your lat comment the "line interpolation" feature saves now as of Mach builds. So if possible review your issue and close it if you're satisfied 🙂

@Kaikogf

This comment has been minimized.

Kaikogf commented Jul 2, 2018

@Jose-Moreno
:)

Great improvements here! All panels changes are now saved when resizing its height and width

About the "line interpolation", here is an issue:
The BRUSH tool is working fine and any change from the Stabiliser (none, simple, strong) is correctly saved when opening pencil2D again.
The PENCIL and PEN tool Stabiliser are working together, meaning that if selecting Strong for the Pencil tool and now going to the Pen tool and selecting None and closing Pencil2D, it will open again with the last selection for BOTH tools ;)

Simple to test it.

Great work into pencil2D ! 👍

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Jul 2, 2018

@Kaikogf Alright so in summary the stabilizer option is only being saved for both Pencil and Brush, but the value is not shared for the Pen tool. I recommend keeping this open then.

@Kaikogf

This comment has been minimized.

Kaikogf commented Jul 2, 2018

@Jose-Moreno
..."but the value is not shared for the Pen tool."
Not exactly. Wherever tool you choose at the end (pen or pencil) its value will be shared with the other tool...

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Jul 2, 2018

This needs to be a global value instead of an individual value that affects each tool then.

@Kaikogf

This comment has been minimized.

Kaikogf commented Jul 2, 2018

@Jose-Moreno
I think my words are not understood correctly. When I say value I am meaning none simple strong.
Picking up None for (lets say the Pen tool) and Simple for the Pencil tool will make the Pen tool to have the Simple "value" when you restart Pencil2D

@CandyFace CandyFace self-assigned this Jul 2, 2018

@CandyFace

This comment has been minimized.

Member

CandyFace commented Jul 2, 2018

The reason it's not being shared with brush is caused by a typo :3
Otherwise that tool would also have its values shared with the other tools. It doesn't make sense to share these values though.
Pull request coming up soon.

@CandyFace

This comment has been minimized.

Member

CandyFace commented Jul 2, 2018

Fixed in #1007

The BRUSH tool is working fine and any change from the Stabiliser (none, simple, strong) is correctly saved when opening pencil2D again.
The PENCIL and PEN tool Stabiliser are working together, meaning that if selecting Strong for the Pencil tool and now going to the Pen tool and selecting None and closing Pencil2D, it will open again with the last selection for BOTH tools ;)

@CandyFace

This comment has been minimized.

Member

CandyFace commented Jul 3, 2018

Any other remarks regarding this issue before I close it?

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Jul 3, 2018

@CandyFace Most of the UI issues discussed in the original post were solved in recent updates along the fix you pushed for the stabilizer problem. So I think this can be closed now. Thank you for stepping in! 😃

@CandyFace CandyFace closed this Jul 3, 2018

@Kaikogf

This comment has been minimized.

Kaikogf commented Jul 3, 2018

Yes, it is all good now. Thanks @CandyFace @Jose-Moreno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment