New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pencil2D crashes when attempting to modify a non-existing first (key)frame #950

Closed
ghost opened this Issue Apr 20, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@ghost

ghost commented Apr 20, 2018

--Issue Summary--

Pencil2D crashes when attempting to modify a non-existing first (key)frame.

--Actual Results--

Pencil2D crashes.

--Expected Results--

Whatever is action is performed should be ignored.

--Video or Image Reference--

image
Attempting to use a tool on the first frame like so will cause the program to crash

--Steps to reproduce--

  1. Create a new project. (This happens in existing projects too.)
  2. Move the first frame of either the Bitmap layer or Vector layer to another position. (The Camera layer doesn't seem to have this problem).
  3. Use a tool on the canvas. (Pencil, selection, etc.)

--System Information--

  • Pencil2D Version:

Version: 0.6.1.1

  • Operating System:

Operating System: Windows 10 (10.0)
CPU Architecture: x86_64

  • RAM Size:

8GB

  • Graphics Tablet:

WACOM Intuos CTL-490

@ghost ghost changed the title from Pencil2D crashes when attempting to modify a non-existing first (key)frame to [BUG] Pencil2D crashes when attempting to modify a non-existing first (key)frame Apr 23, 2018

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented May 10, 2018

I've confirmed this bug with the reproduction steps above. It will happen as long as you try to draw in any empty frame before the first keyframe. Also got this crash report in Windows 7:

Problem Event Name: APPCRASH
Application name: pencil2d.exe
Application version: 0.0.0.0
Application Timestamp: 5ae29848
Fault module name: ucrtbase.DLL
Fault module version: 10.0.10240.16390
Fault module timestamp: 55a5b718
Exception code: 40000015
Exception Offset: 0000000000065a5f

Version: 0.6.1.1
commit: 827cddb
date: 2018-04-27_13:17:37
Development build
Operating System: Windows 7 SP 1 (6.1)
CPU Architecture: x86_64

@chchwy chchwy added the bug label May 10, 2018

CandyFace added a commit to CandyFace/pencil that referenced this issue May 26, 2018

@CandyFace CandyFace self-assigned this May 26, 2018

@CandyFace CandyFace added this to the 0.6.2 milestone May 26, 2018

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented May 28, 2018

@CandyFace I have to add some details. It was reported today that exporting under these conditions also trigger a crash. So If you move the first frame forward and try to export a movie like that, it will trigger the crash as well.

@CandyFace

This comment has been minimized.

Member

CandyFace commented May 28, 2018

@Jose-Moreno Yup I can see that, looking into it currently.

@CandyFace

This comment has been minimized.

Member

CandyFace commented May 29, 2018

The mentioned crash when exporting has been fixed now too in #984

chchwy added a commit that referenced this issue May 31, 2018

Merge pull request #984 from CandyFace/fix-#950
Look for next frame if previous doesn't exist - #950
@CandyFace

This comment has been minimized.

Member

CandyFace commented Jun 1, 2018

Fix will be available in next nightly build, so i'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment