New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Color name not preserved. Palette.xml file does not update after saving or exporting #958

Closed
Jose-Moreno opened this Issue May 1, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Jose-Moreno
Member

Jose-Moreno commented May 1, 2018

--Issue Summary--

I noticed this when exporting a palette as an xml file. I changed the color name. Then exported the current palette xml file and it maintained the previous default color name.
I changed the name again for a different color, saved the file, and reloaded the file, and the name wasn't preserved either. The only way I could have the name changed was changing the name manually on the XML and importing the palette file which isn't ideal.

This was tested with both bitmap and vector layers selected.

--Expected Results--

  • Saving the pencil project file should preserve the name change for any given color in the palette.
  • Exporting a palette.xml file should also preserve the name changes.

--Steps to reproduce--

  1. Open Pencil2D
  2. Pick a random palette color. Change it's name
  3. Save the Pencil2D File
  4. Go to File > Export > Palette > Give it a name and Save it.
  5. Reload the Pencil2D File. Notice that your Palette name has not changed from default
  6. Go to File > Import > Palette > Choose the palette.xml file form step 4.
  7. Also notice the name has not been preserved.

--System Information--

  • Pencil2D Version:
    Version: 0.6.1.1
    commit: 827cddb
    date: 2018-04-27_13:17:37
    Development build
    Operating System: Windows 7 SP 1 (6.1)
    CPU Architecture: x86_64

@chchwy chchwy added the bug label May 10, 2018

@chchwy chchwy self-assigned this May 22, 2018

@chchwy chchwy added this to the 0.6.2 milestone May 22, 2018

@chchwy chchwy closed this in ba81f85 May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment