New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vector eraser tool #1058

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@scribblemaniac
Contributor

scribblemaniac commented Sep 4, 2018

The distance to points was being calculated incorrectly since the dot product produces the square of the eulerian distance. There were also differences in how the vector eraser width was being calculated compared to the bitmap tools (particularly, it takes into consideration the scaling, which we removed I think). Overall these fixes will make the vector eraser less broken, but I would not go as far as to say completely fixed.

Please test to make sure that the pressure is working reasonably as I don't have a tablet to test this with at the moment.

Improve vector eraser tool
The distance to points was being calculated incorrectly since
the dot product produces the *square* of the eulerian distance.

There were also differences in how the vector eraser width was
being calculate compared to the bitmap tools (particularly,
it takes into consideration the scaling, which we removed I think)

@chchwy chchwy merged commit 0d9e385 into pencil2d:master Sep 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chchwy chchwy added this to the 0.6.2 milestone Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment