Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes that can prevent users from duplicate layer names #1087

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@davidlamhauge
Copy link
Contributor

davidlamhauge commented Oct 3, 2018

It is a hidden bug in Pencil2D, that users can have duplicate layer names.
It is unlikely that anyone would name their layers with the same name, but it should not be possible at all. This PR would mend this bug - as I call it.

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 4, 2018

Thanks @davidlamhauge
It's a simple solution to stop users from creating duplicated layer name.

We can implement the layer name increments later on.

@chchwy chchwy merged commit 6075bdf into pencil2d:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chchwy chchwy added this to the 0.6.3 milestone Oct 5, 2018

@davidlamhauge davidlamhauge deleted the davidlamhauge:diffLayerNames branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.