Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename suggestion (numbers) for new layers in Pencil2D #1091

Merged
merged 4 commits into from Oct 7, 2018

Conversation

Projects
None yet
3 participants
@davidlamhauge
Copy link
Contributor

davidlamhauge commented Oct 5, 2018

A function added that suggest new filenames, that differ from existing ones.
If you want a new "Bitmap Layer" and a "Bitmap Layer" exists, it will suggest "Bitmap Layer 2" as filename, and so on.

{
return s;
}
int j = 2;

This comment has been minimized.

Copy link
@CandyFace

CandyFace Oct 5, 2018

Member

Not a strict requirement but I find it to be a bad habit and generally dislike seeing one char variable names. when possible/(when you remember) please name variables something that makes sense to the context. j for example could be named "increment" and string could be named "name".

it's a small thing but it improves code readability a lot.

This comment has been minimized.

Copy link
@davidlamhauge

davidlamhauge Oct 5, 2018

Author Contributor

Whether it's a bad habit, I don't know, but I tend to use bool b, String s, and int i, j and k.
Being aware that I work on a project with many contributors, I will of course try to apply to the coding style.

@CandyFace
Copy link
Member

CandyFace left a comment

LGTM 👍

I have no objections, only a small comment regarding code readability.

Good work David

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 7, 2018

@chchwy chchwy merged commit 227c3d0 into pencil2d:master Oct 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidlamhauge davidlamhauge deleted the davidlamhauge:filenamesuggestion branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.