Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a frame pool cache option #1102

Merged
merged 9 commits into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@0x72D0
Copy link
Contributor

0x72D0 commented Oct 6, 2018

PR for #1076

@Jose-Moreno Jose-Moreno requested review from chchwy and scribblemaniac Oct 7, 2018

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 7, 2018

Seems the frame pool size won't take effect immediately after changing it in preferences?

@0x72D0

This comment has been minimized.

Copy link
Contributor Author

0x72D0 commented Oct 7, 2018

yes from what I seen the frame pool cache is set at the beginning of the program and I don't really know how to change it immediately after changing it in the preference... That why I only put a little warning to restart the program each time the value is changed

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 8, 2018

Okay no worries. I will take care of the rest of the parts.

@0x72D0

This comment has been minimized.

Copy link
Contributor Author

0x72D0 commented Oct 8, 2018

ok, thanks!

@chchwy chchwy added this to the 0.6.3 milestone Oct 9, 2018

@chchwy chchwy merged commit 3b51e5b into pencil2d:master Oct 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 11, 2018

Merged. Thank you @0x72D0

@Jose-Moreno Jose-Moreno removed the request for review from scribblemaniac Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.