Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 1101: Range spinboxes set uneditable at startup #1103

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@davidlamhauge
Copy link
Contributor

davidlamhauge commented Oct 7, 2018

I've added two lines of code that set the spinboxes unabled at startup.
I have tried to open Pencil2D from command line, with a pclx-file as parameter. This file was saved with range set to 1-16, and that range was still active after loading the scene, so it works whether you open Pencil2D with or without a scene.

@davidlamhauge

This comment has been minimized.

Copy link
Contributor Author

davidlamhauge commented Oct 7, 2018

Hmmm.... I added two lines of code. Nothing dangerous.
@scribblemaniac , @CandyFace or others: Any ideas what could make it fail the checks?

@scribblemaniac

This comment has been minimized.

Copy link
Member

scribblemaniac commented Oct 7, 2018

Looks like it's building for this commit which doesn't exist anymore, causing an error. I wouldn't worry about it too much.

@CandyFace
Copy link
Member

CandyFace left a comment

LGTM 👍

@CandyFace

This comment has been minimized.

Copy link
Member

CandyFace commented Oct 7, 2018

Weird that travis failed... did you by any chance do a rebase --force or something?

@davidlamhauge

This comment has been minimized.

Copy link
Contributor Author

davidlamhauge commented Oct 7, 2018

Weird that travis failed... did you by any chance do a rebase --force or something?

Not a rebase --force, but I did a 'git pull origin master' which is pretty much the same, as far as I can read.
If that master I am pulling from is not accepted by the quality check, then... - well - i don't understand the mechanisms here.

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 7, 2018

Sometimes the checkchanges.sh fails for no reason. Don't worry about it.

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Oct 9, 2018

Thank you @davidlamhauge and @CandyFace

@chchwy chchwy merged commit ea1895a into pencil2d:master Oct 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@chchwy chchwy added this to the 0.6.3 milestone Oct 9, 2018

@davidlamhauge davidlamhauge deleted the davidlamhauge:iss1101_rangebox branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.